feat: Experiment and dataset improvements #6163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
anticorrelator
changed the title
axiomofjoy
changed the title
axiomofjoy
reviewed
Jan 27, 2025
anticorrelator
force-pushed
the
dustin/propagate-metadata
branch
from
7aecb06 to
6d59100
Compare
mikeldking
reviewed
Jan 29, 2025
| if span_kind == LLM: | ||
| return _get_llm_span_input( | ||
| input_messages=input_messages, | ||
| input_value=input_value, | ||
| input_mime_type=input_mime_type, | ||
| prompt_template_variables=prompt_template_variables, | ||
| tool_definitions=tool_definitions, |
There was a problem hiding this comment.
can we just double check that this works with openai ft format? also it might be just simpler if the key was tools
mikeldking
reviewed
Jan 29, 2025
| if tool_definitions_data := [ | ||
| _safely_json_decode(tool_definition) for tool_definition in tool_definitions | ||
| ]: | ||
| input["tool_definitions"] = tool_definitions_data |
There was a problem hiding this comment.
Suggested change
| input["tool_definitions"] = tool_definitions_data | |
| input["tools"] = tool_definitions_data |
Kinda leaning this direction. Does this work with openai ft / evals format?
There was a problem hiding this comment.
looks like the tool definitions are a key alongside the input:
https://platform.openai.com/docs/guides/fine-tuning#preparing-your-dataset-for-dpo
mikeldking
reviewed
Jan 31, 2025
| @@ -795,7 +795,7 @@ async def chat_completion_create( | |||
| elif isinstance(event, anthropic_streaming.InputJsonEvent): | |||
| raise NotImplementedError | |||
| else: | |||
| assert_never(event) | |||
| assert_never(event) # type: ignore | |||
There was a problem hiding this comment.
There's a fix for this that @RogerHYang put out. It's the anthropic citations event. Can you cherry pick that and remove this ignore?
dosubot
bot
added
size:L
axiomofjoy
approved these changes
Feb 3, 2025
|
|
||
| # ToolAttributes | ||
| LLM_TOOLS = SpanAttributes.LLM_TOOLS | ||
| TOOL_DEFINITION = ToolAttributes.TOOL_JSON_SCHEMA |
There was a problem hiding this comment.
Maybe we can rename to TOOL_JSON_SCHEMA for consistency with the name of the convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6082
resolves #6153
resolves #6139